Skip to content

DAOS-19133 common: Adjust engin logs severity names#18483

Draft
grom72 wants to merge 8 commits into
masterfrom
grom72/DAOS-19133
Draft

DAOS-19133 common: Adjust engin logs severity names#18483
grom72 wants to merge 8 commits into
masterfrom
grom72/DAOS-19133

Conversation

@grom72

@grom72 grom72 commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adjust severity names in engine logs to follow ones defined for server

  • DBUG → DEBUG
  • ERR → ERROR
  • EMRG → FATAL

Support for redundant EMRG messages has been removed, as they are no longer used anywhere following their unification with the FATAL type.

The minimum length of the facility field should has been increased to 6 to cover all existing facility names.
This will make sure the start of the log line message stays in the same place, no matter where it comes from.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Ticket title is 'Adjust severity names in engine logs to follow ones defined for server'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-19133

@grom72 grom72 force-pushed the grom72/DAOS-19133 branch from 5206b7b to e45cb63 Compare June 10, 2026 13:10
@daosbuild3

daosbuild3 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18483/1/execution/node/1039/log

@daosbuild3

daosbuild3 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18483/2/execution/node/378/log

@grom72 grom72 force-pushed the grom72/DAOS-19133 branch from 50de9d5 to e436d97 Compare June 23, 2026 20:11
@daosbuild3

daosbuild3 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18483/5/testReport/

grom72 added 2 commits June 25, 2026 08:02
@grom72
DAOS-19133 common: Adjust engin logs severity names
36649a3 
Adjust severity names in engine logs to follow ones defined for server
- DBUG → DEBUG
- ERR → ERROR
- EMRG → FATAL

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
DAOS-19133 common: remove obsolete log level: EMRG
fdfde53 
EMRG is no longer used and always can be subsituted by FATAL

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 force-pushed the grom72/DAOS-19133 branch from ec59f14 to 7053f8e Compare June 25, 2026 06:06
grom72 added 3 commits June 25, 2026 08:20
@grom72
Ignore log lines without PID info (DAOS[pid/tid/uid])
42b9e0e 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
Addjust search command ERROR instead of ERR
d2d8661 
Log lines with errors starts with `ERROR` not `ERR` word.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
Ensure log message always begins at the same position in the line.
2d7756c 
The minimum length of the facility field should has been increased to 6 to
cover all existing facility names. This will make sure the start of the log
line message stays in the same place, no matter where it comes from.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 force-pushed the grom72/DAOS-19133 branch from 3c6ad79 to 2d7756c Compare June 25, 2026 06:20
@daosbuild3

daosbuild3 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Test stage NLT completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18483/9/execution/node/636/log

@grom72
Fix log parser
9f65082 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@daosbuild3

daosbuild3 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18483/10/testReport/

grom72 added 2 commits June 25, 2026 12:05
@grom72
Revert "Ensure log message always begins at the same position in the …
51264d1 
…line."

This reverts commit 2d7756c.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false
@grom72
Fix: increase log size as we use longer severity names
7b05ed3 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Cancel-prev-build: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grom72 @daosbuild3